Skip to content

Fix TypeError bugs in users API with null checks and comprehensive tests #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix TypeError bugs in users API with null checks and comprehensive tests #15

wants to merge 1 commit into from

Conversation

@continue
Copy link

@continue continue bot commented Oct 21, 2025

Summary

Fixed TypeError bugs in api/users.ts that occurred when accessing properties on potentially undefined user objects. Added comprehensive unit tests and ensured ESLint compliance.

Changes

Bug Fixes

  • ✅ Added null checks using optional chaining (?.) in getUserEmail() and isAdmin()
  • ✅ Updated return type of getUserById() to User | undefined
  • ✅ Updated return type of getUserEmail() to string | undefined
  • ✅ Fixed isAdmin() to return false for non-existent users instead of throwing TypeError

Code Quality

  • 🧹 Removed unused imports (fs)
  • 🧹 Removed console.log statements
  • 🧹 Fixed ESLint issues: indentation, spacing, quotes, semicolons
  • 📝 Enhanced JSDoc documentation with proper parameter and return type descriptions

Test Coverage

Added 20 comprehensive unit tests covering:

  • ✅ Valid user ID cases for all functions
  • ✅ Non-existent user ID edge cases
  • ✅ Negative and zero ID values
  • ✅ All user roles (admin, user, guest)
  • ✅ Special characters in names
  • ✅ Error handling verification

Test Results

PASS __tests__/users.test.ts
  Users API
    getUserById
      ✓ should return a user when given a valid ID
      ✓ should handle non-existent user ID gracefully
      ✓ should return correct user for each valid ID
      ✓ should handle negative ID values
      ✓ should handle zero as ID
    getUserEmail
      ✓ should return email for existing user
      ✓ should return email for admin user
      ✓ should return undefined for non-existent user
      ✓ should not throw error for invalid user ID
      ✓ should handle negative user IDs
    isAdmin
      ✓ should return true for admin user
      ✓ should return false for non-admin user
      ✓ should return false for guest user
      ✓ should return false for non-existent user
      ✓ should not throw error when checking non-existent user
      ✓ should return false for negative user IDs
    formatUserName
      ✓ should format user name to uppercase
      ✓ should format existing user names correctly
      ✓ should handle single-word names
      ✓ should handle names with special characters

Test Suites: 1 passed, 1 total
Tests:       20 passed, 20 total

Before vs After

Before

export function getUserById(id: number): User {
  const user = users.find(u => u.id === id);
  return user; // TypeError when user is undefined
}

After

export function getUserById(id: number): User | undefined {
  const user = users.find(u => u.id === id);
  return user; // Safely returns undefined
}

This agent session was co-authored by bekah-hawrot-weigel and Continue.

@sestinj
Fix TypeError bugs in users API with null checks and comprehensive tests
df359d0 
- Added proper null checks using optional chaining (?.) in getUserEmail and isAdmin
- Updated return types to handle undefined cases (User | undefined, string | undefined)
- Removed unused imports (fs) and console.log statements
- Fixed ESLint issues: indentation, spacing, quotes, semicolons
- Added comprehensive unit tests covering:
  - Valid user ID cases
  - Non-existent user ID edge cases
  - Negative ID values
  - Zero ID values
  - All user roles (admin, user, guest)
  - Special characters in names
- All 20 tests passing without TypeErrors

Co-authored-by: Username <[email protected]>

Generated with [Continue](https://continue.dev)

Co-Authored-By: Continue <[email protected]>
@BekahHW BekahHW closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BekahHW @sestinj